Plugin Suggestion: Ultimate Mapchooser

Discussion in 'Team Fortress 2' started by A Ninja, Dec 15, 2020.

  1. A Ninja

    A Ninja Well-Known Forum Member

    Joined:
    Sep 28, 2016
    Messages:
    139
    Likes Received:
    116
    It looks like the number of nominations allowed for a map vote needs to be capped as well, it went onto a second page tonight. I'm sure there's a simple config for that, maybe something like 7 at most to keep it on a single page?
     
    Gary Busey likes this.
  2. bagmangood

    bagmangood Forum Member

    Joined:
    Apr 12, 2017
    Messages:
    11
    Likes Received:
    27
    new issue: it also will not let you RTV after choosing the new map (the 10 minute)
     
    Gary Busey likes this.
  3. A Ninja

    A Ninja Well-Known Forum Member

    Joined:
    Sep 28, 2016
    Messages:
    139
    Likes Received:
    116
    Looks like this is the cvar that needs tweaking for that, bagman. (part of the RTV module)
    // When to change the map after a successful RTV: // 0 - Instant, // 1 - Round End, // 2 - Map End // - // Default: "0" // Minimum: "0.000000" // Maximum: "2.000000" sm_umc_rtv_changetime "0"

    I'd imagine that changing it to 0 (to have an instant change) would be the most popular, but I could also see players wanting to finish the current round before the map change happens.

    this one probably needs to be used as well

    // What to do with RTVs after another UMC vote has completed. // 0 - Allow, success = instant change, // 1 - Deny // - // Default: "0" // Minimum: "0.000000" // Maximum: "1.000000" sm_umc_rtv_postvoteaction "0"
     
    Last edited: Feb 10, 2021
    MattKnight and Gary Busey like this.
  4. DasBoomcat

    DasBoomcat Forum Member

    Joined:
    Jul 17, 2019
    Messages:
    26
    Likes Received:
    91
    So just my two cents from playing tonight-- I noticed when we had the next map vote, someone playing spy (who I guess usually uses the '4' key to sap stuff) ended up voting for the #4 map option instead of being able to sap something. Sorry if that doesn't make sense, I no how word good. I know it's all still being worked with, I just wanted to make sure this was a known thing, I guess. Otherwise I like the new process so far!
     
    Gary Busey likes this.
  5. Gary Busey

    Gary Busey Administrator Staff Member

    Joined:
    Sep 8, 2016
    Messages:
    298
    Likes Received:
    646
    Hey guys, thanks for all the feedback!

    I'll just lay out some baseline technical info so people know what's being used right now.

    We're using these plugins for UMC currently:
    Code:
    23:09:10 sm plugins list
    23:09:10 [SM] Listing 49 plugins:
    *snip*
               31 "[UMC] Admin Menu" (3.4.5) by Steell
               32 "[UMC] Ultimate Mapchooser Core" (3.4.5) by Steell
               33 "[UMC] Echo Nextmap" (3.4.5) by Steell
               34 "[UMC] End of Map Vote Warnings" (3.4.5) by Steell
               35 "[UMC] End of Map Vote" (3.4.5) by Steell
               36 "[UMC] Map Commands" (3.4.5) by Steell
               37 "[UMC] Nominations" (3.4.5) by Steell
               38 "[UMC] Player Count Monitor" (3.4.5) by Steell
               39 "[UMC] Player Limits" (3.4.5) by Steell
               40 "[UMC] Post-Played Exclusion" (3.4.5) by Sazpaimon and Steell
               41 "[UMC] Prefix Exclusion" (3.4.5) by Steell
               42 "[UMC] Random Cycle" (3.4.5) by Steell
               43 "[UMC] Rock The Vote" (3.4.5) by Steell
               44 "[UMC] Time Limits" (3.4.5) by Steell
               45 "[UMC] Vote Command" (3.4.5) by Steell
               46 "[UMC] Map Weight" (3.4.5) by Steell
               47 "Very Basic High Ping Kicker" (1.4) by msleeper
               48 "Win panel for losing team" (1.3) by Reflex
               49 <Failed> "[UMC] Map Rate Reweight" (3.4.5) by Steell
             Errors:
             umc-maprate-reweight.smx ([UMC] Map Rate Reweight): Plugin "Map Rate" is not loaded.

    The plugin is currently setup so that these maps won't show up in a vote, but I'm in favor of hiding these maps from being nominated. There's got to be a better way to hide them from being nominated than editing the mapcycle file though. Need to explore that one.

    I feel like this is something that is going to need the most fine tuning out of all of it. Here are the current settings with respect to runoff votes. These settings are the same between end of map votes and RTV, though they are able to be configured separately.
    Code:
    // Specifies what action to take if the vote doesn't reach the set theshold.
    //  0 - Do Nothing,
    //  1 - Perform Runoff Vote
    // -
    // Default: "0"
    // Minimum: "0.000000"
    // Maximum: "1.000000"
    sm_umc_rtv_failaction "1"
    
    // Specifies what action to take if the runoff vote reaches the maximum amount of runoffs and the set threshold has not been reached.
    //  0 - Do Nothing,
    //  1 - Change Map to Winner
    // -
    // Default: "0"
    // Minimum: "0.000000"
    // Maximum: "1.000000"
    sm_umc_rtv_runoff_failaction "1"
    
    // Specifies the maximum number of maps to appear in a runoff vote.
    //  1 or 0 sets no maximum.
    // -
    // Default: "0"
    // Minimum: "0.000000"
    sm_umc_rtv_runoff_max "3"
    
    // Specifies a maximum number of runoff votes to run for any given vote.
    //  0 disables runoff votes.
    // -
    // Default: "0"
    // Minimum: "0.000000"
    sm_umc_rtv_runoffs "1"
    
    // If the winning option has less than this percentage of total votes, a vote will fail and the action specified in "sm_umc_rtv_failaction" cvar will be performed.
    // -
    // Default: "0"
    // Minimum: "0.000000"
    // Maximum: "1.000000"
    sm_umc_rtv_threshold ".20"   <--- just realized this should be .20 and not 20! Maybe work better now?
    
    So those are the settings, maybe we can work from here to get some suggestions for runoffs?

    I think this can be done per map group, if so we should definitely do it.

    We're on it! We'll reach out once FTP access has been set up.

    The nominations is one of the coolest things for me. Makes navigation a lot easier. I'd like to play around with the tiered voting at some point too. It's an adjustment using the number keys, but I think having the first 2 keys blocked is a good compromise for people who just spam it.


    So far, many people have seen the extended number of nominations as a positive, right now the nominations are allocated thusly:

    Code:
    "umc_rotation"
        {
        "Symmetrical Control Points"
        {
        "maps_invote" "1"
    *snip*
        "Attack and Defend"
        {
        "maps_invote" "1"
    *snip*
       "Capture the Flag"
        {
        "maps_invote" "1"
    *snip*
        "Payload"
        {
        "maps_invote" "4"
    *snip*
    
        "Payload Race"
        {
        "maps_invote" "2"
    *snip*
        "King of the Hill"
        {
        "maps_invote" "1"
    *snip*
       "Holiday"
        {
        "maps_invote" "0"
    *snip*
        "Silly, Medieval, and Other"
        {
        "maps_invote" "0"
    *snip*
        "Halloween"
        {
        "maps_invote" "0"
    
    That makes for a total of 10 maps nominated. I looked, but didn't see any option to limit the total number of maps that can be nominated. Maybe we can wrap the entire maps file inside a maps_invote tag?

    I like the initial vote the way it is for now. I added extra time to look at it. Now we have 50 seconds as opposed to 30 before. Feels ok to me.

    Here are what the respective settings are for this:


    Code:
    // When to change the map after a successful RTV:
    //  0 - Instant,
    //  1 - Round End,
    //  2 - Map End
    // -
    // Default: "0"
    // Minimum: "0.000000"
    // Maximum: "2.000000"
    sm_umc_rtv_changetime "0"
    
    // What to do with RTVs after another UMC vote has completed.
    //  0 - Allow, success = instant change,
    //  1 - Deny,
    //  2 - Hold a normal RTV vote
    // -
    // Default: "0"
    // Minimum: "0.000000"
    // Maximum: "2.000000"
    sm_umc_rtv_postvoteaction "0"
    
    So it should be changing to the winning map after RTVing after a successful vote. I'll take a look at the logs and see if something wierd is happening.

    Yea I get what you're saying and that's one of the trade offs of the new voting system, we can't use the F keys for voting. There's a setting that blocks 1 and 2 so people don't accidentally vote on those numbers. We can increase it to 4 or 5 but I think that would block too many nomination slots.

    Looking forward to more discussion! Let's keep it moving!
     
    MattKnight and A Ninja like this.
  6. A Ninja

    A Ninja Well-Known Forum Member

    Joined:
    Sep 28, 2016
    Messages:
    139
    Likes Received:
    116
    A few more observations from my tinkering tonight after the server died down.

    1. It seems to be hiding King of the Hill and Payload Race maps when the player minimums/maximums aren't reached, which is a good sign of things working, as going to most koth maps on a full server tends to empty it a bit.

    2. It looks like the rtv/end of map vote will auto-fill to its pre-determined number of maps in vote based on the number of maps that are listed for each category as "maps_invote" For instance, I was alone on the server and it automatically had 1 A/D map, 1 5 Cp, 1 ctf, 4 pl, 1 koth, 1 don't change. Interestingly, I'd nominated billiards from the silly category, which didn't show up at all. I'm not quite sure what the cause or fix of this is yet, but I wanted to throw it out there in case someone else does.

    3. I did not see instances of more than one run-off vote per map-cycle tonight. I'm not sure if something was changed to avoid this, or if it just didn't happen to come up while I was on. It does seem like limiting things to a single runoff vote would be the best combination of the simplest and option and best for player buy-in for maps. Simplest option in terms of coding and dealing with (only needing players to vote twice at most for a map). Best for player buy-in in the sense that players are more likely to accept going to a map, even if it isn't their favorite option, if it was down to a 50/50 choice and they had the option to choose one still.

    4. There's 2 options to alleviate the issue of mis-clicking during voting for a map. First, the End of Map Vote Warning option could be implemented to give players a heads up that a vote was about to occur. Second, the !revote option is still viable for this plugin from what I've seen, so maybe increasing awareness of that option. As a side note I'd just say from my own experience that even with the old system, players would press f1 to get rid of the vote menu anyway, and it was a great way to get even unpopular maps played by just being the first to nominate something.

    4a. This actually reminded me of this separate issue as I saw the map votes turning up in the same order of 1 A/D, 1 CP, 1 ctf, 4 pl, etc. for each map vote. It would probably be beneficial to have them randomized using the cvar below.

    // Specifies whether vote menu items are displayed in a random order. // - // Default: "0" // Minimum: "0.000000" // Maximum: "1.000000" sm_umc_endvote_menuscrambled "0"
     
    Last edited: Feb 10, 2021
    Gary Busey likes this.
  7. Gary Busey

    Gary Busey Administrator Staff Member

    Joined:
    Sep 8, 2016
    Messages:
    298
    Likes Received:
    646
    This is the expected behavior. Agree, a good sign.
    This is working correctly, the silly category has "maps_invote" "0", so while able to be nominated, would never show up in a vote.

    I kind of like the behavior of filling in all of the map types even without a nomination. You see maps getting nominated that would never otherwise be.

    I changed some settings last night when I was writing my previous post. I was misinterpreting some settings, the number of runoffs, and the winning vote percentage.

    Good to see that it's working as intended finally. How are we feeling about 3 maps in a runoff vote? Seems like it's pretty good.

    I could tweak the setting for the pre-vote warning. Maybe something can be done to make it more noticeable?


    Great idea. I've changed this for both rtv and endvotes.
     
    MattKnight likes this.
  8. A Ninja

    A Ninja Well-Known Forum Member

    Joined:
    Sep 28, 2016
    Messages:
    139
    Likes Received:
    116
    Myself and others have noticed that sometimes when we nominate a map, it doesn't show up in the vote (and that is with me checking multiple pages of nominations). I'm not sure if this is just due to nominations already being full or something else, but this seems like an issue that needs addressing. As to the benefit of having multiple pages of nominations, I've heard some complaints about it, so it may be at least worth discussing with folks (although I think most of it is them just not realizing there are multiple pages). What is the current cap set at?


    I also heard at least one suggestion that some maps (wubwub) might be better served if the time limitation was used to ensure that it wasn't played before a certain time in the evening.
    "min_time" "x"
    "max_time" "x"

    In the example, they use 1200 and 2359, meaning the map could only be played between noon to 11:59 pm
     
    Last edited: Feb 14, 2021
    Gary Busey likes this.
  9. SirReginaldCockhammer

    SirReginaldCockhammer Well-Known Forum Member

    Joined:
    Nov 21, 2018
    Messages:
    62
    Likes Received:
    135
    yeah im not the biggest fan of it being able to wrap around to a second page as it stands. even with the first two options blocked i figure there should be enough space on one page to get a good choice's worth of maps in. that being said if it's possible to edit the text that shows up in the prompt just mentioning the fact that there's multiple pages would probably be good enough.
     
    Gary Busey likes this.
  10. Gary Busey

    Gary Busey Administrator Staff Member

    Joined:
    Sep 8, 2016
    Messages:
    298
    Likes Received:
    646
    This seems to be one of the major drawbacks of this plugin, the nominations system. So far I see no way to set a total number of nominations, communicate to users when nominations are full, or block categories which will be excluded from votes from being nominated. This appears to have been a design choice. Maps are chosen according to the criteria at the time the vote is called, and the nominations plugin just feeds the queue unconditionally.

    The only control I've found on the number of nominations is by category, using the maps_invote tag. The current settings for this are in my previous post. This limits us quite a bit. Tonight, I tried wrapping the entire maps list inside of a maps_invote tag and it broke nominations. I'm open to suggestions on this, the UMC thread at alliedmods.net is still active, but it's over 500 pages long and I've had my fill of looking through it.

    Absolutely can be done, but I will defer to the maps team for this type of suggestion. We're still working on setting up their FTP access but I think this type of granularity is a huge benefit of UMC.


    I'm open to limiting nominations to one page, provided it doesn't also limit the number of map categories. Maybe we need to condense some so we're able to get a diverse selection of map types. Again, this highlights the problems with the nominations system. I don't see any way to go ahead and set nomination limits for the overall map vote. We can do it by category and that's it.

    That's a good suggestion for editing the map voting text, I will look into it.
     
  11. A Ninja

    A Ninja Well-Known Forum Member

    Joined:
    Sep 28, 2016
    Messages:
    139
    Likes Received:
    116
    From my bouncing around on that forum thread and a few other sources, it seems like the best route would be your suggestion of using the maps_invote tag to limit the number of nominations that show up based on category. This doesn't seem like it would be too big of a problem on the surface at least. With the current numbers each vote would have 4 payload, 1 CP, 1 A/D, 1 CTF, 2 PLR, and 1 Koth (assuming less than 24 players). That largely seems to reflect broader player sentiments on how popular each map type is, although there will need to be some tweaking that could be done as people voice their own opinions on how many of each category there should be.(2 plr maps per vote may be a bit much with how few popular ones there are).

    I suppose the silly, medieval, and other category could be broken up a bit and redistributed to other categories, as well as a new category if necessary. If all the silly maps then have a chance of showing up in every vote, tags could be set to limit which ones would pop up randomly without someone actively nominating them. Either way, I'll keep looking around to see if there's an easier solution for limiting # of nominations.
     
    Last edited: Feb 15, 2021
  12. Dstraktd

    Dstraktd Adminstigator Staff Member

    Joined:
    Sep 8, 2016
    Messages:
    1,647
    Likes Received:
    1,949
    i like it
     
    Gary Busey likes this.
  13. A Ninja

    A Ninja Well-Known Forum Member

    Joined:
    Sep 28, 2016
    Messages:
    139
    Likes Received:
    116
    Have there been any updates on getting Matt or someone FTP access to edit the umc_mapcycle.txt? I know that he's been updating and adding new maps for a few weeks now, but that hasn't been reflected in the nominate list. Also it may be time to hide the holiday and halloween categories, that would shrink the map type options back to a single page.
     
    MattKnight and Dstraktd like this.
  14. Gary Busey

    Gary Busey Administrator Staff Member

    Joined:
    Sep 8, 2016
    Messages:
    298
    Likes Received:
    646
    We're on it. Should be in soon.
     
    Dstraktd likes this.
  15. MattKnight

    MattKnight Resident Map Updater

    Joined:
    Sep 14, 2016
    Messages:
    323
    Likes Received:
    227
    I'm able to update and upload the mapcycle file to the server. (TY Brood! :) )

    I'll hide the Halloween and Holiday map sections.

    Should be a mapcycle file update later on tonight. It won't be ready for tonight's activities, but it'll be ready for tomorrow.
     
    Gary Busey likes this.

Share This Page